Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated protobuf ptypes #942

Merged

Conversation

aradwann
Copy link
Contributor

No description provided.

@aradwann
Copy link
Contributor Author

@kamikazechaser Hi, I reworked the PR without the extra fmt part

Copy link
Contributor

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We could upgrade protobuf as well? (in place of #932)

@aradwann aradwann requested a review from pior October 28, 2024 11:37
Copy link
Contributor

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in internal/proto/asynq.pb.go look safe 👍

@pior
Copy link
Contributor

pior commented Oct 28, 2024

Ready for #811

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixes a couple of security issues.

@kamikazechaser kamikazechaser merged commit e70de72 into hibiken:master Oct 29, 2024
8 checks passed
@aradwann aradwann deleted the remove-deprecated-protobuf-ptypes branch October 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants