Skip to content

Reproducer for HHH-19855 <convert> at entity level is ignored in orm.xml #11108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

Reproducer for HHH-19855 <convert> at entity level is ignored in orm.xml #11108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...test/java/org/hibernate/orm/test/mapping/converted/converter/SimpleXmlOverriddenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.hibernate.type.Type;
import org.hibernate.type.descriptor.java.StringJavaType;
import org.hibernate.type.descriptor.jdbc.spi.JdbcTypeRegistry;
import org.hibernate.type.internal.BasicTypeImpl;
import org.hibernate.type.internal.ConvertedBasicTypeImpl;

import org.hibernate.testing.junit4.BaseUnitTestCase;
Expand Down Expand Up @@ -82,10 +83,27 @@ public void testDefinitionAtAttributeLevel() {

PersistentClass pc = metadata.getEntityBinding( TheEntity.class.getName() );
BasicType<?> type = (BasicType<?>) pc.getProperty( "it" ).getType();
assertTyping( BasicTypeImpl.class, type ); // Should not be ConvertedBasicTypeImpl in particular
assertTyping( StringJavaType.class, type.getJavaTypeDescriptor() );
assertTyping( jdbcTypeRegistry.getDescriptor( Types.VARCHAR ).getClass(), type.getJdbcType() );
}

/**
* A baseline test, with an explicit @Convert annotation at entity level that should be in effect
*/
@Test
public void baselineAtEntityLevel() {
Metadata metadata = new MetadataSources( ssr )
.addAnnotatedClass( TheEntity2.class )
.buildMetadata();

PersistentClass pc = metadata.getEntityBinding( TheEntity2.class.getName() );
Type type = pc.getProperty( "it" ).getType();
ConvertedBasicTypeImpl adapter = assertTyping( ConvertedBasicTypeImpl.class, type );
final JpaAttributeConverter converter = (JpaAttributeConverter) adapter.getValueConverter();
assertTrue( SillyStringConverter.class.isAssignableFrom( converter.getConverterJavaType().getJavaTypeClass() ) );
}

/**
* Test outcome of applying overrides via orm.xml, specifically at the entity level
*/
Expand All @@ -101,6 +119,7 @@ public void testDefinitionAtEntityLevel() {

PersistentClass pc = metadata.getEntityBinding( TheEntity2.class.getName() );
BasicType<?> type = (BasicType<?>) pc.getProperty( "it" ).getType();
assertTyping( BasicTypeImpl.class, type ); // Should not be ConvertedBasicTypeImpl in particular
assertTyping( StringJavaType.class, type.getJavaTypeDescriptor() );
assertTyping( jdbcTypeRegistry.getDescriptor( Types.VARCHAR ).getClass(), type.getJdbcType() );
}
Expand Down
Loading