-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19626 Hibernate processor may fail to process entities with generics #10584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19626 Hibernate processor may fail to process entities with generics #10584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cigaly, appreciated. Please see my comments.
First, the fix works, so that's great.
But I think it's generally a bad idea to keep this sort of state in the processor, and so I would lean toward making these just functions.
tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/TypeUtils.java
Outdated
Show resolved
Hide resolved
...model-generator/src/main/java/org/hibernate/processor/util/GenericTypeParameterResolver.java
Outdated
Show resolved
Hide resolved
...model-generator/src/main/java/org/hibernate/processor/util/GenericTypeParameterResolver.java
Outdated
Show resolved
Hide resolved
tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/TypeUtils.java
Fixed
Show fixed
Hide fixed
…otation processor
b039a5a
to
8639ee5
Compare
That's why I'm saying that code needs some "polishing" |
8639ee5
to
f7d240e
Compare
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
b02aaa6
to
f7d240e
Compare
This is looking pretty reasonable now. @cigaly let me know when you're ready to go ahead with it. |
I've mistakenly pushed and later deleted some commits, but now it is OK. If you do not have any suggestions (or complaints), that's it. And later I can suggest some changes for what is described in HHH-19326 |
Perfect, thanks! |
Jira issue HHH-19626
Test case from PR#10574
Created helper class
org.hibernate.processor.util.GenericTypeParameterResolver
used for generic type parameters resolutionBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.