Skip to content

HHH-19626 Hibernate processor may fail to process entities with generics #10584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cigaly
Copy link
Contributor

@cigaly cigaly commented Jul 18, 2025

Jira issue HHH-19626

Test case from PR#10574

Created helper class org.hibernate.processor.util.GenericTypeParameterResolver used for generic type parameters resolution


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cigaly, appreciated. Please see my comments.

First, the fix works, so that's great.

But I think it's generally a bad idea to keep this sort of state in the processor, and so I would lean toward making these just functions.

@cigaly cigaly force-pushed the HHH-19626-Hibernate-processor-may-fail-to-process-entities-with-generics branch from b039a5a to 8639ee5 Compare July 20, 2025 06:35
@cigaly
Copy link
Contributor Author

cigaly commented Jul 20, 2025

But I think it's generally a bad idea to keep this sort of state in the processor, and so I would lean toward making these just functions.

That's why I'm saying that code needs some "polishing"

@cigaly cigaly force-pushed the HHH-19626-Hibernate-processor-may-fail-to-process-entities-with-generics branch from 8639ee5 to f7d240e Compare July 20, 2025 10:01
@cigaly cigaly marked this pull request as ready for review July 20, 2025 12:17
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jul 22, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@cigaly cigaly force-pushed the HHH-19626-Hibernate-processor-may-fail-to-process-entities-with-generics branch from b02aaa6 to f7d240e Compare July 22, 2025 09:49
@gavinking
Copy link
Member

This is looking pretty reasonable now. @cigaly let me know when you're ready to go ahead with it.

@cigaly
Copy link
Contributor Author

cigaly commented Jul 22, 2025

I've mistakenly pushed and later deleted some commits, but now it is OK. If you do not have any suggestions (or complaints), that's it.

And later I can suggest some changes for what is described in HHH-19326

@gavinking gavinking merged commit a8c6132 into hibernate:main Jul 22, 2025
41 of 42 checks passed
@gavinking
Copy link
Member

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants