Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cloudflare nodejs_compat_v2 example #639

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Sep 9, 2024

Reviving #630

For now, we don't integrate it out-of-the-box. Let's use it as an example. It loos like nodejs_compat_v2 is becoming the default soon, so let's get on it.

https://developers.cloudflare.com/workers/configuration/compatibility-dates/#nodejs-compatibility-flag

On September 23, 2024, nodejs_compat will use the improved Node.js compatibility currently enabled with nodejs_compat_v2.

Also experiment:... is not needed anymore since wrangler 3.73


Side note: Nitro/unenv is probably relying on the convention of globalThis.__env__ to be exposed as process.env. If we also use unenv's inject then we could get on that convention as well:

Copy link
Owner Author

hi-ogawa commented Sep 9, 2024

@hi-ogawa hi-ogawa marked this pull request as ready for review September 9, 2024 08:07
Copy link
Owner Author

hi-ogawa commented Sep 9, 2024

Merge activity

  • Sep 9, 4:40 AM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Sep 9, 4:49 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 9, 4:53 AM EDT: @hi-ogawa merged this pull request with Graphite.

@hi-ogawa hi-ogawa changed the base branch from feat-server-dot-env to graphite-base/639 September 9, 2024 08:42
@hi-ogawa hi-ogawa changed the base branch from graphite-base/639 to main September 9, 2024 08:47
@hi-ogawa hi-ogawa merged commit 4c63f6f into main Sep 9, 2024
10 checks passed
@hi-ogawa hi-ogawa deleted the feat-cf-node-compat branch September 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant