Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tiny-react): insert children in reverse order to simplify insertBefore #170

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

refactor(tiny-react): insert children in reverse order to simplify insertBefore #170

wants to merge 9 commits into from
+43 −52

Conversation

hi-ogawa
Copy link
Owner

Maybe this is not so common, but probably this is what yew does internally.
As seen in the test snapshot, the consequence of that is each VCustom.render would run in reverse order.

@hi-ogawa
refactor(tiny-react): traverse children in reverse order to simplify …

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: DBFD3C6008EA9A66
Learn about vigilant mode
eead95f 
…`Node.insertBefore`
@hi-ogawa
fix: no reattach on mutating reconcilation

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: DBFD3C6008EA9A66
Learn about vigilant mode
15d616e
@hi-ogawa hi-ogawa mentioned this pull request Oct 19, 2023
Open
@hi-ogawa hi-ogawa marked this pull request as ready for review October 19, 2023 04:30
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was signed with the committer’s verified signature. The key has expired.
hi-ogawa Hiroshi Ogawa
GPG key ID: 7CCD88EAABB445C1
Expired
Verified
Learn about vigilant mode
b720834
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b6b9a75
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was signed with the committer’s verified signature. The key has expired.
hi-ogawa Hiroshi Ogawa
GPG key ID: 7CCD88EAABB445C1
Expired
Verified
Learn about vigilant mode
e473193
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
abac11f
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
7302c46
@hi-ogawa hi-ogawa mentioned this pull request May 5, 2024
Merged
hi-ogawa added 2 commits May 5, 2024 12:14
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
de32e23
@hi-ogawa
Merge branch 'main' into refactor-tiny-react-reverse-insert-order

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
146651f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hi-ogawa