-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update registry.k8s.io/sig-storage/csi-resizer docker tag to v1.13.1 #847
base: main
Are you sure you want to change the base?
deps: update registry.k8s.io/sig-storage/csi-resizer docker tag to v1.13.1 #847
Conversation
3577a6a
to
5f64d5a
Compare
5f64d5a
to
6476348
Compare
Kubernetes v1.32 and csi-resizer v1.13.1 have a beta feature gate on by default. This causes compatibility issues with csi-resizer v1.13.1 and Kubernetes < v1.32. To mitigate this we could enable/disable the feature gate in the csi-resizer via a helm check against What do you think @apricote ? Ref: |
Conditionally disabling the feature flag sounds like the best solution to me. If someone wants this configurable we can still add that later on. |
I agree. We can also change it when the feature moves out of beta. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
imagePullPolicy: IfNotPresent | ||
resources: | ||
limits: {} | ||
requests: {} | ||
args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes an issue, you need to make sure that it uses an empty array if nothing is defined, pretty sure we have an example for this between HCCM and csi-driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved it by adding the args
key depending if either leading election is enabled or if the feature gate should be disabled.
@apricote I ran into an issue, which I first did not realize locally, due to an outdated helm version. As skaffold uses Furthermore, I noticed that we would have to make a decision on how to move further with the snapshots. Should we enable or disable the feature gate there? I'd probably go for disabling, as it will break deployments otherwise. This though has the consequence of having to provide Should we make it a feature flag in the values then? |
Annoying. Just checked the docs, For That said, if you are keen on it, you can make it a feature flag, but needs to be documented that it will be removed when upstream removes the flag. |
This PR contains the following updates:
v1.12.0
->v1.13.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.