Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md based on guidelines #86

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Update README.md based on guidelines #86

merged 11 commits into from
Mar 18, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Mar 5, 2024

This PR updates the README.md according to the guideline set forth here.

To view the README.md without the diff: https://github.com/heroku/buildpacks-php/blob/readme-update/README.md

I didn't add any PHP specifics. Leaving these for @dzuelke:

  • Add app requirements section (something about composer.json?)
  • Add configuration section (how to select runtimes and/or extensions?)

@joshwlewis joshwlewis marked this pull request as ready for review March 5, 2024 02:16
@joshwlewis joshwlewis requested a review from a team as a code owner March 5, 2024 02:16
@joshwlewis joshwlewis marked this pull request as draft March 5, 2024 02:22
@joshwlewis joshwlewis marked this pull request as ready for review March 5, 2024 02:55
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@runesoerensen
Copy link
Contributor

@dzuelke Any changes before we merge this in (see Josh's comment here #86 (comment))?

README.md Outdated Show resolved Hide resolved
@runesoerensen runesoerensen merged commit 123696d into main Mar 18, 2024
5 checks passed
@runesoerensen runesoerensen deleted the readme-update branch March 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants