Skip to content

Add opt-in Pi prompt-time Fidelis recall - #67

Merged
roli-lpci merged 3 commits into
mainfrom
feature/pi-prompt-recall
Sep 23, 2026
Merged

roli-lpci merged 3 commits into
mainfrom
feature/pi-prompt-recall

Conversation

@roli-lpci

Copy link
Copy Markdown
Member

What changed

  • Add an opt-in native Pi extension that calls the configured local Fidelis /recall_b service before a user turn with at least three non-whitespace Unicode characters.
  • Show up to three verbatim retrieved passages in a visible, labeled Pi context message. Keep older recall messages out of later model context and compaction. The extension makes no memory writes.
  • Bound the local call to one second and the response stream to 64 KiB before JSON parsing. Unavailable, stalled, invalid, or oversized responses leave the Pi turn usable.
  • Document installation, behavior, and limitations. This is prompt-time recall, not an MCP tool or generic memory store.

Verification

  • node --experimental-strip-types --test tests/test_pi_recall.mjs: 9/9 passing, including Unicode minimum-prompt and oversized-response fake-server cases.
  • Real Pi v0.87.1 --mode json --print probe against a running local Fidelis service emitted one visible fidelis-pi-recall message with exact source text; a no-service probe completed without injection or error.
  • hermes-gate fast --base origin/main: PASS, committed diff SHA 873be7e8c9725ed8e1af303afc174686ebf3547c6f4c252511b7d275d172b921.
  • hermes-gate review --base origin/main: PASS, zero findings, same committed diff and head eb8a20d4c6e732b15f8dba7392d427d1d1f2c833.

Local full-suite status

Gate full is not required locally by this repository's profile. An earlier local full run did not pass: Ruff reported 242 existing errors and pytest hit its 180-second timeout. The same Ruff count and timeout were reproduced on a clean detached main worktree before this final adapter correction. This PR does not claim a passing full-suite run.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c3db41e2-106f-4b25-9744-86f724b86028

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roli-lpci
roli-lpci merged commit e75c039 into main Sep 23, 2026
12 checks passed
@roli-lpci
roli-lpci deleted the feature/pi-prompt-recall branch September 23, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant