Add opt-in Pi prompt-time Fidelis recall - #67
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/recall_bservice before a user turn with at least three non-whitespace Unicode characters.Verification
node --experimental-strip-types --test tests/test_pi_recall.mjs: 9/9 passing, including Unicode minimum-prompt and oversized-response fake-server cases.--mode json --printprobe against a running local Fidelis service emitted one visiblefidelis-pi-recallmessage with exact source text; a no-service probe completed without injection or error.hermes-gate fast --base origin/main: PASS, committed diff SHA873be7e8c9725ed8e1af303afc174686ebf3547c6f4c252511b7d275d172b921.hermes-gate review --base origin/main: PASS, zero findings, same committed diff and headeb8a20d4c6e732b15f8dba7392d427d1d1f2c833.Local full-suite status
Gate full is not required locally by this repository's profile. An earlier local full run did not pass: Ruff reported 242 existing errors and pytest hit its 180-second timeout. The same Ruff count and timeout were reproduced on a clean detached main worktree before this final adapter correction. This PR does not claim a passing full-suite run.