Transparently inject default values for parameters into handler arguments #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqasn
force-pushed
the
default-values
branch
from
f04a513 to
d9f44c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that you don't have to repeat yourself (and maybe even introduce subtle bugs) by having to manually fall back to the default in the handler.
I had to add a patch to openapi-typescript for this to work properly, which is still pending review: openapi-ts/openapi-typescript#2528
In order to demonstrate the feature, I have added a prerelease version of my forked library in a
removeme:commit.Again this is based on the refactored multi-package structure, the relevant commits is ee87617