Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Patches for reDIRECT, Hephaistos, and Bluedog DB. #105

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

CessnaSkyhawk
Copy link

No description provided.

@hemeac
Copy link
Owner

hemeac commented Aug 2, 2021

I'll take a look at this in a couple days, just behind on some other work that needs to take priority, but thanks for sending over

@CessnaSkyhawk
Copy link
Author

Alright - works great for me actually, as I can hopefully finish up the Kerbalism patches by then anyways

@hemeac
Copy link
Owner

hemeac commented Aug 3, 2021

In general, they look good, but I am guessing you have copied and pasted some bits from the files that you are developing? The files that you've sent in the pull request don't have have the cfg extensions so won't be detected by MM.

Can you also remove the patch in the BDB cfg that adds the part name to the description? While useful for debugging, that's out of scope for the mod. In general, also want to avoid any :FINAL passes that are in distributed mods, best practice is only for personal patches.

@CessnaSkyhawk
Copy link
Author

Alright - both should be fixed in a minute. The .cfg issue was due to me still figuring out PRs, and the part name patch was just me being dumb and forgetting to delete it when I was done editing 😅

@CessnaSkyhawk
Copy link
Author

Alright - should be all done now. Last thing left is trying my hand at Kerbalism experiments. I've got the part adding pre-configured KTT/Kerbalism experiments to BDB science stuff done, but the couple custom experiments I'm trying (Keyhole spy sats and Nimbus weather sats) are presenting some difficulty. I'll commit what I've got so far (the preconfig stuff), and then see how those other experiments work out.

@Sadaell
Copy link

Sadaell commented Aug 8, 2021

@CessnaSkyhawk, I'm also slowly adding Kerbalism/BDB experiments. If you want I can send you some of my patches including weather, sigint and few long term telescopes experiments, but it might take some time since right now they are completely mess.
Also maybe you should use wildcards instead of adding experiments to certain parts because some other mods like Coatl utilize BDB's SciDefs instead of their own if BDB is installed.

@CessnaSkyhawk
Copy link
Author

@Sadaell I actually just about wrapped my patch up aside from a few minor tweaks and science value balancing things, but if you want to compare notes at some point it probably wouldn't hurt.

@CessnaSkyhawk
Copy link
Author

In general all the science experiments should hopefully be supported now in my PR, but there's still one or two more things I might want to do - specifically, I want to try and retrofit the stock Kerbalism SigInt scan into an experiment for the "Meadow" mapping cam and the Thresher sigint scanner to try and differentiate them from the Keyhole stuff.

I'm also a little concerned about the balance of certain experiments - especially CORONA for sigint and the three extraplanetary (KARS/WAMUU/ESIDISI) weather ones, but I'm likely just gonna test that by doing a playthrough myself and seeing whats what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants