enhance matching #193
Open
enhance matching #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronhurt
force-pushed
the
ahurt/enhance-matching
branch
from
fd9f581 to
f444867
Compare
aaronhurt
force-pushed
the
ahurt/enhance-matching
branch
from
e348005 to
331aa41
Compare
This commit reworks matching. The new matcher ignores spacing and order differences from Helm. The format of the `Map.yaml` file has been simplified to reflect these changes. The README.md has been updated, and a new converter tool has been provided. The current `Map.yaml` in this PR was generated from the previous `Map.yaml` via the converter. Signed-off-by: Aaron Hurt <[email protected]>
govulncheck reported the following vulnerability. Vulnerability #1: GO-2025-3528 containerd has an integer overflow in User ID handling in github.com/containerd/containerd More info: https://pkg.go.dev/vuln/GO-2025-3528 Module: github.com/containerd/containerd Found in: github.com/containerd/[email protected] Fixed in: github.com/containerd/[email protected] Updated to github.com/containerd/[email protected] and ran tests. Ran 9 of 9 Specs in 0.002 seconds SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 0 Skipped --- PASS: TestCommon (0.00s) PASS ok github.com/helm/helm-mapkubeapis/pkg/common (cached) ? github.com/helm/helm-mapkubeapis/pkg/mapping [no test files] ? github.com/helm/helm-mapkubeapis/pkg/v3 [no test files] Signed-off-by: Aaron Hurt <[email protected]>
aaronhurt
force-pushed
the
ahurt/enhance-matching
branch
from
331aa41 to
31e9186
Compare
|
Hello, thank you for your PR, this branch has some conflicts could you please correct this and we can take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks matching. The new matcher ignores spacing and order differences from Helm. The format of the
Map.yamlfile has been simplified to reflect these changes. The README.md has been updated, and a new converter tool has been provided. The currentMap.yamlin this PR was generated from the previousMap.yamlvia the converter.This PR is breaking in it's current state, it will only accept the new
Map.yamlformat, but as stated previously a converter has been provided.