Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.go #748

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update index.go #748

wants to merge 3 commits into from

Conversation

wutongjie23hao
Copy link
Contributor

the chartversions of index.yaml should be equal to the length of chartversion objects in storage backend. if not equal, we should regenerate the index.yaml.

the chartversions of index.yaml should be equal to the length of chartversion objects in storage backend. if not equal, we should regenerate the index.yaml.

Signed-off-by: Xiaolei.Liang <[email protected]>
Signed-off-by: liangxiaolei5 <[email protected]>
liangxiaolei5 added 2 commits January 31, 2024 09:56
Signed-off-by: liangxiaolei5 <[email protected]>
Signed-off-by: liangxiaolei5 <[email protected]>
@scbizu
Copy link
Contributor

scbizu commented Feb 1, 2024

I prefer to not accept this PR , since we already have internal-cache option and always-regenerate-chart-index option on the other hand , this kind of feature seems duplicate . What do you think ? @cbuto

@wutongjie23hao
Copy link
Contributor Author

I prefer to not accept this PR , since we already have internal-cache option and always-regenerate-chart-index option on the other hand , this kind of feature seems duplicate . What do you think ? @cbuto

always regenerate index only when the depth set a certain value. This is not valid when we set flag '--depth-dynamic'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants