Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support raw api (#715) #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

allenhaozi
Copy link

@allenhaozi allenhaozi commented Sep 8, 2023

support raw api

Hi @cbuto @scbizu, as for this raw api, submit a pr version,

please review it. If you have any questions, please feedback to me. Thank you

#715

c.JSON(err.Status, gin.H{"error": err.Message})
return
}
chrt, err1 := loader.LoadArchive(bytes.NewReader(storageObject.Content))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put this in pkg/repo/chart.go, and provide a function like GetChartRawdate() ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your review
I tried to wrap a function like you said, but I got an error import cycle not allowed
That would require a bigger change, what's your opinion? whether this larger change is needed

@scbizu
Copy link
Contributor

scbizu commented Sep 17, 2023

And also , could you add some testing code to prove the feature is worked as expected ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants