Skip to content

Tablet and Phone Interface Improvements #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

hello-vinitha
Copy link
Collaborator

@hello-vinitha hello-vinitha commented May 13, 2025

Description

This PR makes a series of changes to improve the tablet and phone view for the interface made in the temp/deployment branch. The tablet view should appear as a scaled down view from the desktop version and the mobile interface has a different layout to make the best use of space.

Currently there are some known issues that need be resolved:

  • In the tablet customization mode some components disappear when another component is added or a component is moved.
  • Button pad buttons sometimes overflow out of the panel depending on the size of the screen.

Testing procedure

  • Test that components can be successfully added, removed and rearranged (desktop, tablet)
  • Verify mobile responsiveness on different screen sizes (tablet & mobile)
  • Verify the correct buttons are being highlighted blue/green when the joint is moving
  • Verify the correct buttons are highlighted red when the respective joint is at it's limit
  • Verify click-to-pregrasp works on (desktop & tablet)
  • Verify that cameras and buttons are sized appropriately for the screen (i.e. buttons/camera are not overflowing or too small, etc.)
  • Verify that all action modes work across desktop and mobile

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@mintyfreshv
Copy link

IMG_2443
Device: phone interface

Issue: the play button and the controls under recordings. Please see screen capture.

@hello-vinitha
Copy link
Collaborator Author

hello-vinitha commented May 30, 2025

To Do List based on @mintyfreshv's feedback:

@hello-william
Copy link
Contributor

great job with this testing @mintyfreshv!

@hello-william
Copy link
Contributor

hi @mintyfreshv i just pushed a fix for the unexpected scrolling that was happening on ipad

can u do a git pull and ./launch_interface.sh to verify the fix works?

@mintyfreshv
Copy link

Screenshot 2025-06-12 at 8 01 28 AM (100% Zoom on Chrome)
Screenshot 2025-06-12 at 8 02 29 AM (50% Zoom on Chrome)

Device: Desktop

The aspect ratio of the interface is off today. The camera views are too small at 100%. The views get better at 50%, but everything else becomes smaller.

@mintyfreshv
Copy link

ScreenRecording_06-12-2025.08-07-13_1.mov

Device: iPad

Issue: button pad overlay on interface is not working.

@mintyfreshv
Copy link

mintyfreshv commented Jun 12, 2025

IMG_0127

Device: iPad

Issue: as seen in the picture, when only the real sense camera view is present on the interface, the camera view is stretched out along with the button pad controls.

Although unlike our meeting with Ashley from ALS Northwest, the camera view here isn’t immensely as wide as when we were with her. However, the botton pads surely look funky.

@hello-william
Copy link
Contributor

@hello-vinitha @mintyfreshv hmmm i'm kinda wondering what's the most efficient way to squash these bugs....... are you two going to meet IRL any time soon?

you can pull me on a call, and we can block out 2-3hrs do a bug squashing marathon... you would need your devices/workstation/#3002 there so we can do everything on the spot

@hello-vinitha
Copy link
Collaborator Author

IMG_0127

Device: iPad

Issue: as seen in the picture, when only the real sense camera view is present on the interface, the camera view is stretched out along with the button pad controls.

Although unlike our meeting with Ashley from ALS Northwest, the camera view here isn’t immensely as wide as when we were with her. However, the botton pads surely look funky.

I was able to replicate this on my IPad but not on chrome dev tools @hello-william. I agree it might be easier for the three of us to meet to squash these bugs. I will coordinate.

@hello-vinitha
Copy link
Collaborator Author

2025-06-12.11-55-02.mp4

Issue: Elements disappear in the when buttons are moved in customization mode.
Device: Desktop
Browser: Chrome
Robot: 3030

@hello-vinitha
Copy link
Collaborator Author

hello-vinitha commented Jun 12, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants