test: cover the strict daemon resolver's missing-file rejection (#145) - #156
Merged
Conversation
The release resolver verify_bundled_binary() already refuses a missing candidate (symlink_metadata errors before any predicate), but mod release_resolver covered accept + world/group-writable file + symlink + world-writable parent (incl. sticky) and never the missing-file case from the issue's reject list. Add that one test so the contract is locked. Default-feature cargo test -p deckard-signerd compiles the strict (not dev-signerd-bin) path, so the test runs in CI's workspace job. Closes #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the one missing case from #145 to
mod release_resolverincrates/deckard-signerd/src/supervise.rs: a test asserting the strict release resolververify_bundled_binary()rejects a missing file.The module already covered accept + group/world-writable file + symlink + world-writable parent (incl. sticky); the missing-file rejection from the issue's list was the only gap. (Production already refuses it via
symlink_metadataerroring before any predicate; this locks that contract.)Why it runs in CI
Default-feature
cargo test -p deckard-signerd(nodev-signerd-bin) compiles the strictnot(dev-signerd-bin)path, so the test executes in CI'slinuxworkspace-test job — the exact path that ships and that #134 slipped through untested.Verification
cargo fmt --all --checkcleancargo test -p deckard-signerd --lib release_resolver→ 6 passed (incl. the newrejects_a_missing_file)cargo clippy -p deckard-signerd --all-targets -D warningscleanCloses #145