feat: expose message signing over browser bridge - #139
Merged
Conversation
0xpantera
force-pushed
the
feature/issue-137-bridge-message-signing
branch
from
June 24, 2026 11:07
e10d6b9 to
b35f4ec
Compare
This was referenced Jul 10, 2026
hellno
added a commit
that referenced
this pull request
Jul 10, 2026
…-bridge doc (#220) - ADR 0006: accept the shipped 127.0.0.1:8765 loopback bridge as the alpha transport (temporary/experimental); native messaging stays the post-audit target; priority is the two ends (core + extension). Resolves the #202 decision. - browser-bridge.md: correct two stale claims — the bridge forwards the full EIP-1193 set (personal_sign / eth_signTypedData_v4 / eth_sendTransaction / EIP-5792), not 'only 3 methods', and those are no longer 'not implemented' (#139/#141/#146/#148, attributed via #198).
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
personal_signandeth_signTypedData_v4through the localhost EIP-1193 browser bridgeeth_signas not clear-signableDependency note
alloy-dyn-abiwith theeip712feature todeckard-browser-bridgeso the bridge can parse and hash dynamic EIP-712 typed data instead of hand-rolling typed-data encoding.Test plan
cargo fmt --all --checkjust checkcargo test --workspacepnpm run qa:extensionpnpm run qa:walletbeatpnpm run qa:walletbeat:signaturesCloses #137