languages.toml: Add GPX extension to XML #14300
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
languages.toml
Outdated
| @@ -2995,7 +2995,8 @@ file-types = [ | |||
| "sublime-snippet", | |||
| "xsl", | |||
| "mpd", | |||
| "smil" | |||
| "smil", | |||
| "gpx" | |||
There was a problem hiding this comment.
Suggested change
| "gpx" | |
| "gpx", |
If we add the comma already (and formatting doesn't complain), that will make future diffs nicer :)
There was a problem hiding this comment.
Makes no difference to me, but there are others which don’t have the trailing comma at the end of file-types:
jsonyamlininginxdebian
Would it be desirable to have a PR to add those as well?
Also, fine by me if a maintainer wants to directly edit the PR or close and do it themselves. I know that’s often faster and easier than having a back and forth discussion. Whatever you prefer.
There was a problem hiding this comment.
Let's add the trailing comma here for now and we can eventually add it to the other languages when there are future modifications to their file-types
Co-authored-by: Poliorcetics <[email protected]>
the-mikedavis
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPS Exchange Format, with a
gpxfile extension, is XML.