Kanagawa: fix palette and attempt at a markdown compromise #12895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current palette curiously doubles
sumiInk2
andsumiInk4
, which is the same color. I took the original palette from Kanagawa and added the color explanations from its readme. Additionally I commented out all colors which are not in use, for a better overview. This operation didn’t change the highlighting, but I had to do a few fixes for the changed sumiInk numbering.Additionally I’m rather unhappy with the current markdown highlighting, because I do quite a bit of note taking and the original Kanagawa doesn’t care about it at all. I installed nvim again to check the theme out in its native environment. First of all we have one “error”,
springViolet1
instead ofoniviolet2
for quotes. This was my own mistake from an earlier pull request. The link color is neither good with or without treesitter on nvim, I suggest to uselightBlue
instead—URLs deserve their very own color. Two more heading colors don’t hurt; and lists are almost invisible right now, I changed them tosakuraPink
. It’s all a matter of taste of course, but in my opinion it becomes more readable and easier to distinguish.@zetashift