fix: do not guess indent if majority is lines with no indent #12810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Err on the side of caution by returning None if the majority of lines has no indentation
After seeing #12783 and then #9556 I had a think about it, and my conclusion is that it's hard to determine when the file has a majority of lines with no indent.
This effectively skews the heuristic to only guess when a certain indent level and type is in excess of lines with no indents.
While playing around with this I found that it will have a hard time on very short scripts that has a lot of includes, but the fallback to config then tab still was fine for me.
I completely understand if this is not in line with what was planned, so feel free to close with no need to explain.