feat: add welcome pack correction jobs and integration tests#1151
Merged
bryzettler merged 2 commits intodevelopfrom Mar 17, 2026
Merged
feat: add welcome pack correction jobs and integration tests#1151bryzettler merged 2 commits intodevelopfrom
bryzettler merged 2 commits intodevelopfrom
Conversation
Add welcome_pack_ownership and welcome_pack_reward_destination polling jobs that re-publish correct ownership/reward data when welcome_packs is indexed after asset_owners. INNER JOIN guards prevent publishing when asset_owners hasn't been indexed yet. Includes 4 integration tests validating the INNER JOIN guard behavior and happy-path resolution for both queries.
ChewingGlass
approved these changes
Mar 17, 2026
d817769 to
21e576c
Compare
Extract shared helpers block_boundary_for_table and next_block_for_table to consolidate duplicated SQL queries across correction job functions. Simplify test helpers with run_block_range_query.
21e576c to
0e4878f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add welcome_pack_ownership and welcome_pack_reward_destination polling jobs that re-publish correct ownership/reward data when welcome_packs is indexed after asset_owners. INNER JOIN guards prevent publishing when asset_owners hasn't been indexed yet.
Includes 4 integration tests validating the INNER JOIN guard behavior and happy-path resolution for both queries.