Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove warnings during tests #6122

Merged
merged 4 commits into from
Jan 22, 2025
Merged

🧹 Remove warnings during tests #6122

merged 4 commits into from
Jan 22, 2025

Conversation

rix0rrr
Copy link
Collaborator

@rix0rrr rix0rrr commented Jan 22, 2025

We were persistently printing 2 deprecation warnings during unit tests. These warning originated from old versions of the Lark parser and the Pydantic library, that were using deprecated Python APIs.

Upgrade both libraries to newer versions; the warnings are now gone.

Because we cache Lark parsers on disk, we need to make sure to mix the Lark version into the cache key so that we don't load old parsers into a new version of the library.

We can't seem to go higher than 1.1.9, because when we do we run into the following parsing problem:

E           exceptions.InvalidArgumentTypeException: Invalid Argument Type {'command': 'forward', 'invalid_type': Markup('text'), 'allowed_types': 'a number or input from `ask`', 'invalid_argument': '100', 'line_number': 1}

We detected that `forward` doesn't work with `100` because it is text. Can you try changing `100` to a number or input from `ask`? at line [1]

How to test

If all tests pass, this is good to go.

We were persistently printing 2 deprecation warnings during unit tests.
These warning originated from old versions of the Lark parser and the
Pydantic library, that were using deprecated Python APIs.

Upgrade both libraries to newer versions; the warnings are now gone.

Because we cache Lark parsers on disk, we need to make sure to mix the
Lark version into the cache key so that we don't load old parsers into a
new version of the library.
Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 22, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6122 has been dequeued. The pull request has been synchronized by a user

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@rix0rrr
Copy link
Collaborator Author

rix0rrr commented Jan 22, 2025

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 22, 2025

requeue

❌ This pull request head commit has not been previously disembarked from queue.

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5709035 into main Jan 22, 2025
11 checks passed
@mergify mergify bot deleted the remove-warnings branch January 22, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants