-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Remove warnings during tests #6122
Conversation
We were persistently printing 2 deprecation warnings during unit tests. These warning originated from old versions of the Lark parser and the Pydantic library, that were using deprecated Python APIs. Upgrade both libraries to newer versions; the warnings are now gone. Because we cache Lark parsers on disk, we need to make sure to mix the Lark version into the cache key so that we don't load old parsers into a new version of the library.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #6122 has been dequeued. The pull request has been synchronized by a user You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
We were persistently printing 2 deprecation warnings during unit tests. These warning originated from old versions of the Lark parser and the Pydantic library, that were using deprecated Python APIs.
Upgrade both libraries to newer versions; the warnings are now gone.
Because we cache Lark parsers on disk, we need to make sure to mix the Lark version into the cache key so that we don't load old parsers into a new version of the library.
We can't seem to go higher than
1.1.9
, because when we do we run into the following parsing problem:How to test
If all tests pass, this is good to go.