🪲 Fix keyword translation when keywords are substrings of each other #6121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6118, we discovered that when the source language keywword is a substring of the target language keyword, we make a mistake in the string replacement.
This happens because we do the following:
a
where the source line actually contained the English keywordat
.In this PR, I'm changing the logic a little: as result of parsing, we already know the location in the line where the keyword occurs, so we can just immediately replace that part of the line with the new keyword.
Two complications that make this slightly less straightforward than it sounds (which are probably the reason why we are doing the additional search&replace in the first place):
Fixes #6118.