💻 New public adventures page #6092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax highlighter used to work by calling `initTranslations()` with the current level and language, which then manipulates global variables so that the syntax highlighter code has the right information to highlight the different levels and languages of Hedy correctly. To remove the need for global variables, we instead parameterize the Lezer parsers and pass the level and language into the generator at every time it is used.
for more information, see https://pre-commit.ci
…nto huijbers/no-global-trans
…nto huijbers/no-global-trans
|
I'm sure the Cypress tests will be broken because I changed a lot about the page. Haven't gotten to those yet. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the UI of the teachers "public adventures" page. It does away with the tabs and replaces it with a scrollable list on the left side. It's also faster and doesn't rely on all requests coming in to a single Python process (which will not be true on Heroku).
This is what it currently looks like:
What we've lost from the old public adventures is the ability to see all public adventures of all languages at the same time... but I figure that real users are interested in a single language only.
How to test
Log in as a teacher, and search and use the interface. Use clone, use flag, use delete if you are
teacher1.