Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] New turtle content for level 1-15 #4791

Merged
merged 82 commits into from
Dec 4, 2023
Merged

Conversation

MarleenGilsing
Copy link
Collaborator

New content for level 1-5 and level 8-9.

@ghost
Copy link

ghost commented Nov 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MarleenGilsing
Copy link
Collaborator Author

@Felienne Hmm... Very angry tests and an error message I dont understand. Would you be able to take a look before next week?

@MarleenGilsing MarleenGilsing changed the title [CONTENT] New turtle content for level 1-5 and 8-9 [CONTENT] New turtle content for level 1-15 Nov 30, 2023
@MarleenGilsing
Copy link
Collaborator Author

@Felienne (or maybe @hasan-sh or @jpelay can help me in case Felienne is too busy in Australia)

I'm having some trouble with the tests again.... It now tells me that two of my code snippets are wrong, which they are not in my view.

It says that level 10 example 2 is wrong because you have to use quotation marks in the list, but this is only from level 12 and up, not level 10. So I don't understand what it wants...

The other example is example 2 in level 13. It says I can't use define. I don't know why not though...

Do you think the tests are mad it is because it's a second example? Eventhough we use them more often in other adventures?

If someone could take a look and maybe merge it that would be great, because the longer we wait the more conflicts appear with the fast translators we have ;) Thank you!

@Felienne
Copy link
Member

Felienne commented Dec 4, 2023

Hi @MarleenGilsing !

This time it was not us haha, you forgot a _ in the code, and then Hedy cannot run it. You can also see this if you try the examples:

image

Although I will admit the error for define is not great:

image

(I will make a separate issue for that!)

@Felienne
Copy link
Member

Felienne commented Dec 4, 2023

Love the Christmas lights by the way!!! Cheers from Australia!

Copy link
Contributor

mergify bot commented Dec 4, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 32cc66b into main Dec 4, 2023
10 checks passed
@mergify mergify bot deleted the new-turtle-content branch December 4, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants