Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic builds for Linux/Windows #24

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Sakimotor
Copy link

First time I do this so I don't know if my workflow is any good, and I did unashamedly cross-reference some github template examples with AI coding tools but after testing them the artifacts seem to run like intended.

@yell0wsuit
Copy link

Neat, but you might want to add the GitHub release step so it's shown in the Releases section.

@Sakimotor
Copy link
Author

Neat, but you might want to add the GitHub release step so it's shown in the Releases section.

Hmmmm I wonder if I've got it right, the if check might be futile but I don't see what other name I could give to the releases

@pnill
Copy link

pnill commented Mar 5, 2025

For future reference, instead of submitting a PR with 19 commits with the same title, you can always git rebase and squash them into a single commit. It looks nicer and easier to follow if the changes are simple/in a single file.

E.X. New commit making changes to same file on top of another commit
git rebase -i HEAD~2 (2 being the number of commits you're rebasing on from current HEAD) will open text editor and you can put a s to squash the new one into the old, then just git push -f to force it over the old history on github.

@halotroop2288
Copy link

You can also just squash-merge the PR to clean up the history while merging it.

@Sakimotor
Copy link
Author

Sakimotor commented Mar 6, 2025

For future reference, instead of submitting a PR with 19 commits with the same title, you can always git rebase and squash them into a single commit. It looks nicer and easier to follow if the changes are simple/in a single file.

E.X. New commit making changes to same file on top of another commit git rebase -i HEAD~2 (2 being the number of commits you're rebasing on from current HEAD) will open text editor and you can put a s to squash the new one into the old, then just git push -f to force it over the old history on github.

I will look into that, thanks. I usually give a minimal description to my commits, but this time I used the website's API so it ends up looking pretty messy and not very informative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants