Make v2 memory lock acquisition configurable and resilient#2
Open
heaoxiang-ai wants to merge 1 commit intomainfrom
Open
Make v2 memory lock acquisition configurable and resilient#2heaoxiang-ai wants to merge 1 commit intomainfrom
heaoxiang-ai wants to merge 1 commit intomainfrom
Conversation
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
while Trueloop to acquire subtree locks, which can block session commits indefinitely under contention.Description
MemoryConfig:v2_lock_retry_interval_secondsandv2_lock_max_retriesto control retry pacing and limits.SessionCompressorV2.extract_long_term_memoriesto honor the new config values, perform paced retries usingasyncio.sleep, and raiseTimeoutErrorwhen the retry limit is hit.test_v2_lock_acquire_respects_max_retriesto validate that the extractor stops retrying after the configured maximum and that the retry loop is exercised.Testing
python -m compileall openviking/session/compressor_v2.py openviking_cli/utils/config/memory_config.py tests/session/memory/test_compressor_v2.pycompleted successfully.tests/conftest.py) failed at import time due to a missingyamldependency in the environment, so the new test was not executed in this run.Codex Task