feat(memory): add configurable read-only toolset for memory extraction#1
Open
heaoxiang-ai wants to merge 1 commit intomainfrom
Open
feat(memory): add configurable read-only toolset for memory extraction#1heaoxiang-ai wants to merge 1 commit intomainfrom
heaoxiang-ai wants to merge 1 commit intomainfrom
Conversation
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
memory.llm_toolsfield toMemoryConfiginopenviking_cli/utils/config/memory_config.pywith a safe default of["read", "search"]and allowed valuesread,search,ls.readto be present for safety invalidate_llm_tools.SessionExtractContextProviderinopenviking/session/memory/session_extract_context_provider.pyto source allowed tools fromget_openviking_config().memory.llm_toolsand to inject the configured tool list into the extraction system instruction.examples/ov.conf.exampleto show"llm_tools": ["read", "search"]and added unit tests intests/test_config_loader.pyto cover defaults, dedup behavior, invalid tool rejection, and the requirement thatreadbe present.Testing
python -m compileall openviking_cli/utils/config/memory_config.py openviking/session/memory/session_extract_context_provider.py tests/test_config_loader.py, which succeeded.MemoryConfiglogic locally, but running the full test suite orpytestin this environment failed due to missing runtime dependencies (yaml,json_repair) and the test bootstrap, so the new tests were not executed underpytesthere.feat(memory): make extraction LLM tools configurableand include the modified example and added tests.Codex Task