Skip to content

Conversation

@ehennestad
Copy link
Contributor

No description provided.

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oruebel oruebel merged commit e6f5975 into hdmf-dev:main May 9, 2025
3 checks passed
@ehennestad
Copy link
Contributor Author

Only comment I have is whether it would be cleaner if the sort_keys of the YamlWriter in hdmf is a static method, but I did not understand where the represent_scalar is defined:

https://github.com/hdmf-dev/hdmf/blob/8edb6d132ce813848ae65f407e49400401126bed/src/hdmf/spec/write.py#L73-L76

@rly
Copy link
Contributor

rly commented May 9, 2025

I think it is defined in yaml.representer.Representer: https://github.com/commx/ruamel-yaml/blob/master/representer.py#L143

Yes, I think it could be a static method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants