Add empty threads info texts and update translations files. #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo Code Review 📊 ✅ All checks passed! |
Signed-off-by: Shoaib Ahmed <[email protected]>
ShoaibIqbal452
force-pushed
the
Add-infotext-for-empty-threads-page
branch
from
867ca25
to
466b961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticker Link: N/A
Context:
While playing around with chats I noticed I had no threads and when I navigated to threads page it seemed all empty and It took me a second to figure out it was all empty. It is not a bug but I felt it would be a good in context of a user to have info/message indicating the threads page is empty.
Changes:
1: Check for empty threads in
Threads.svelte.2: Add a div to display empty threads info incase threads are empty.
3: Declare translation strings in plugin.
4: Update all translation files using google translate.
Impact:
If there are no threads empty threads page displays infotext now which improved user experience.
Steps to reproduce
Create a new workspace with no users. Navigate to chat and then to threads page.