apply review comments

Signed-off-by: denis-tingaikin <[email protected]>
hcengineering · Mar 7, 2025 · ef28fec · ef28fec
1 parent 024f07e
commit ef28fec
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 244 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/models/recorder/package.json b/models/recorder/package.json
@@ -28,15 +28,10 @@
     "typescript": "^5.3.3"
   },
   "dependencies": {
-    "@hcengineering/core": "^0.6.32",
     "@hcengineering/model": "^0.6.11",
     "@hcengineering/model-core": "^0.6.0",
-    "@hcengineering/model-presentation": "^0.6.0",
-    "@hcengineering/model-workbench": "^0.6.1",
     "@hcengineering/platform": "^0.6.11",
-    "@hcengineering/ui": "^0.6.15",
     "@hcengineering/uploader": "^0.6.0",
-    "@hcengineering/uploader-resources": "^0.6.0",
     "@hcengineering/recorder": "^0.6.0",
     "@hcengineering/recorder-resources": "^0.6.0"
   }

diff --git a/plugins/recorder-resources/package.json b/plugins/recorder-resources/package.json
@@ -48,15 +48,6 @@
     "@hcengineering/uploader": "^0.6.0",
     "@hcengineering/view": "^0.6.13",
     "@hcengineering/view-resources": "^0.6.0",
-    "@uppy/core": "^3.13.1",
-    "@uppy/dashboard": "^3.9.1",
-    "@uppy/drag-drop": "^3.1.1",
-    "@uppy/locales": "^4.0.3",
-    "@uppy/progress-bar": "^3.1.1",
-    "@uppy/screen-capture": "^3.2.0",
-    "@uppy/status-bar": "^3.3.3",
-    "@uppy/webcam": "^3.4.2",
-    "@uppy/xhr-upload": "^3.6.8",
     "install": "^0.13.0",
     "stream-browserify": "^3.0.0",
     "svelte": "^4.2.19",

diff --git a/plugins/uploader-resources/src/components/FileUploadStatusPopup.svelte b/plugins/uploader-resources/src/components/FileUploadStatusPopup.svelte
@@ -47,24 +47,16 @@
 
   function handleCancelAll (): void {
     upload?.files.forEach((element) => {
-      if (element.cancel !== undefined) {
-        element.cancel()
-      }
+        element.cancel?.()
     })
   }
 
   function handleCancelFile (file: FileUpload): void {
-    if (file.cancel === undefined) {
-      return
-    }
-    file.cancel()
+    file.cancel?.()
   }
 
   function handleRetryFile (file: FileUpload): void {
-    if (file.retry === undefined) {
-      return
-    }
-    void file.retry()
+    void file.retry?.()
   }
   onMount(() => {
     return uploads.subscribe(updateState)

diff --git a/plugins/uploader-resources/src/utils.ts b/plugins/uploader-resources/src/utils.ts
@@ -116,9 +116,7 @@ export async function uploadFile (
       progress: 0
     }
     fileUpload.retry = async () => {
-      if (fileUpload.cancel !== undefined) {
-        fileUpload.cancel()
-      }
+      fileUpload.cancel?.()
       await uploadFile(file, metadata, upload, options)
     }