-
Notifications
You must be signed in to change notification settings - Fork 12
Handle cmd+k #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Handle cmd+k #281
Conversation
✅ Deploy Preview for lucid-bassi-1dc305 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Can we add the hint text to the bottom of the window too so people know they can use this? |
|
@oliverhowell Great idea but I don't know where to put it, so it's always visible... Maybe let's widen the search button and add it there?
|
|
@oliverhowell But in order to see that panel you should already open the search overlay... So that hint will be useless... Unless we just want to make the users depressed pointing out that they had a perfect chance to use CMD+K but missed it :) |
I don't think the first use is a concern - if we add the shortcut we should include it alongside the panel describing the other shortcuts. Frequent users will remember it; it's not a problem for users only to discover it once the panel is open imo. |
|
@oliverhowell How do you like this? |



The search bar should open with CMD+K on mac and CTRL+K on windows