Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm registry with deno update syntax #107

Closed
wants to merge 3 commits into from

Conversation

levibostian
Copy link

Fixes: #96

udd takes a npm import npm:ical-generator@^4.0.0 and converts that to npm:[email protected]#^ from this line of code

The npm regex gives you the version string of 4.0.0#^ which SemVer() fails at.

This PR fixes the problem by getting the version from npm:[email protected]#^ to return 4.0.0 instead of 4.0.0#^.

@levibostian levibostian closed this May 5, 2023
@levibostian levibostian reopened this May 6, 2023
@levibostian levibostian closed this May 6, 2023
@levibostian
Copy link
Author

Huh. I guess github will not let you reopen a PR once the branch has been force pushed.

I had to keep this closed and open a new one. #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working correctly with npm specifier
1 participant