Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable import of dashboads from $GF_DASHBOARDS_PATH #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akram
Copy link

@akram akram commented Apr 20, 2017

Uses the dashboards.json section, enables it and set the path of json dashboards to automatically be imported on startup

Uses the dashboards.json section, enables it and set the path of json dashboards to automatically be imported on startup
@jotak jotak self-requested a review April 24, 2017 07:43
Copy link
Collaborator

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garethahealy any other comment?

--config=/etc/grafana/grafana.ini \
cfg:default.paths.data="$GF_PATHS_DATA" \
cfg:default.paths.logs="$GF_PATHS_LOGS" \
cfg:default.dashboards.json.enabled=GF_DASHBOARDS_ENABLED \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$" is missing on GF_DASHBOARDS_ENABLED

@@ -3,10 +3,14 @@
: "${GF_PATHS_DATA:=/var/lib/grafana}"
: "${GF_PATHS_LOGS:=/var/log/grafana}"
: "${GF_PATHS_PLUGINS:=/var/lib/grafana/plugins}"
: "${GF_DASHBOARDS_ENABLED:=true}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep "false" as the default, and override to true when wanted? docker run -e "GF_DASHBOARDS_ENABLED=true" -i -p 3000:3000 (etc.)

@garethahealy
Copy link
Contributor

Looks fine other than your minor comments @jotak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants