Accept more HTIDs #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ingest does extensive validation of htids, so we don't necessarily need to do that here as well. This was rejecting uiuc IDs with underscores; rather than adding underscore to the regex, just accept any non-empty HTID.
moseshll
approved these changes
Jan 30, 2025
Contributor
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
This is a reasonable level of validation since here we're more concerned with the shape of the lines rather than the format of the constituent HTIDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingest does extensive validation of htids, so we don't necessarily need to do that here as well. This was rejecting uiuc IDs with underscores; rather than adding underscore to the regex, just accept any non-empty HTID.