Fix off-by-one error in linecount comparison between hathifile and it… #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s source catalog - The hathifiles verifier was written when derivative dates were file datestamps - The source zephir file datestamp was calculated as the hathifile minus one day - After the datestamp delta logic was added to the derivative classes, this "minus one" should have been removed - This patch adds and exposes a `catalog_source` method for testability
mwarin
approved these changes
Jan 16, 2025
Contributor
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
looks good, no notes
APPROVE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s source catalog
catalog_sourcemethod for testability