ETT-1251 OTIS download stats should only track when users have switch… #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to ATRS or RS roles - Check `access_type` in addition to `role` when determining if a log entry is relevant for the database. - Update spec fixtures with some red herrings but expect the test counts to stay the same -- the red herrings are ignored. - No changes to database schema.
aelkiss
approved these changes
Jan 16, 2026
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
This looks correct to me, with the caveat that I haven't directly reviewed the logs to confirm that ssd_proxy_user is present. That is at least the value in RightsGlobals.pm, though.
Collaborator
Author
|
@aelkiss I poked at the imgsrv logs when Ange and I were talking thru the issue on Slack -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed to ATRS or RS roles
access_typein addition torolewhen determining if a log entry is relevant for the database.