ETT-1142 OTIS download report: filters with dropdown menus should inc… #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lude all possible values for that field - Proof of concept which does not update values based on other popup menu selections (will test for viability) - Add `HTDownload` method `all_values` called by the presenter to populate the menus
aelkiss
reviewed
Jan 13, 2026
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
I added some comments about generating the filter list -- we don't need rights_date or pages. Performance seems OK for me in testing; if we run into issues in production with the joins to hathifiles we may consider alternate ways of getting the possible values.
Works fine for me in testing.
data_filter_data is a bit messy as you say, but we're likely to clean up at least some of that in the future, and I think the only remaining exception will be 'role'.
The tests all look fine.
- Set `pages` and `rights_date_used` to "input" rather than "select" - Remove support for these fields in `HTDownload.all_values`
Collaborator
Author
|
I mentioned on the ticket, should build and deploy to staging and see what the performance looks like. |
Collaborator
Author
|
@aelkiss Performance info noted on ticket. I think I'm good with what we have. |
aelkiss
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lude all possible values for that field
HTDownloadmethodall_valuescalled by the presenter to populate the menus.HTDownloadPresentercalls this method indata_filter_datanow for allselectcolumns, not justrole.data_filter_datahas key == value, butroleis still a special case, as it was before.full_downloadin subsequent work.This branch is currently on
otis-testing