Include icus items for deposit holdings analysis #413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the deposit holdings analysis is primarily for resource sharing which is (for now) a US-based service, we wanted to include icus material in that analysis.
This also exposes functionality for the mock solr response to include different records or queries, which could be useful for certain kinds of testing.
Arguably we shouldn't include nobody or pd-pvt for the purposes of this analysis since resource sharing people can't get access ot them, but the rights codes are at least now included in the report output so we can filter them out if desired.
This definitely exposes a bit of a question about how we consider what's "in copyright" for different purposes; it probably doesn't make sense to have a unilateral definition of that for holdings; future needs around overlap reporting focused around particular services might help clarify this.