ETT-1178: option to skip type checking #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is desirable when for example we are loading a new members' holdings, one type passes validation, but another doesn't; if we then fix the one that failed, we get the complaint about type mismatch (since only one type of data was loaded before). This is also potentially an issue when formats do change and we want to manually back up, delete, and then reload. Again, when loading new data, we can run into this problem if some passes the validation & we load it but other data doesn't. Longer-term, we should think about: * by default, loading data only if *all* submitted files are valid * being able to specify a particular file to scrub & load when needed * automating the reload process when formats change (ETT-253)
Member
Author
liseli
approved these changes
Dec 10, 2025
Contributor
liseli
left a comment
liseli
left a comment
There was a problem hiding this comment.
These changes seem fine to me
Contributor
|
Ditto Lianet's comment. This will definitely be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is desirable when for example we are loading a new members' holdings, one type passes validation, but another doesn't; if we then fix the one that failed, we get the complaint about type mismatch (since only one type of data was loaded before).
This is also potentially an issue when formats do change and we want to manually back up, delete, and then reload. Again, when loading new data, we can run into this problem if some passes the validation & we load it but other data doesn't.
Longer-term, we should think about: