HTAE-13: Use Debian 13 base image

[aelkiss]

• use library-packaged grokj2k
• use more Debian packaged perl modules

[aelkiss]

Playwright tests pass locally for me.

@moseshll n.b. Ryan has built both arm64 and amd64 grokj2k debs.

[aelkiss]

The perl tests pass locally for me too. I'll see what's failing here.

[aelkiss]

Looks like imgsrv is failing. I'll try a clean checkout & build locally and see if I can reproduce.

[aelkiss]

perl tests pass for me locally even with a clean checkout & build w/o using cache. I'm rather confused. I think first I'm just going to re-try the tests here.

[moseshll]

Looks like grok is getting confused by the -num_threads argument. I'm getting the failure locally.

[aelkiss]

Interesting; I wonder why I'm not getting it. I'll look into it further.

[moseshll]

/usr/bin/grk_decompress -h claims the flag is --num-threads and makes no mention of -num_threads, I dare to suspect the developer did a bit of a tidy-up on the option style sometime recently.

And indeed, if I change imgsrv/lib/Process/Image.pm to use the "dash variant" then perl-test passes okay.

There's a case to be made for using the short form -H which appears to be unchanged between our build and the debian testing/unstable ones.

[aelkiss]

Thanks for looking into it. I think when I did the clean check-out to see if tests were passing locally it was using the wrong branch. Also there may have been some caching issues because even on the right branch when I built & then ran the perl-test container it was debian 12. 🤦

[rrotter]

Suggested change

	RUN apt-get update && apt-get install -y \
	RUN apt-get update && apt-get install -y --no-install-recommends \

This mirrors APT::Install-Recommends "false", which is in the global apt settings on all of our servers. This will occasionally leave a package in a broken state, but if it does, we want to know about it and add necessary dependencies explicitly.

[rrotter]

Suggested change

	RUN apt-get update && apt-get install grokj2k
	RUN apt-get update && apt-get install -y --no-install-recommends grokj2k

I would be surprised if this works without -y, unless you happen to be installing all of grok's deps above.

[moseshll]

There are a total of five uses of the old grok -num_threads option. I would recommend changing the remaining four to use -H (I have no experience with recompress so I don't know if it is needed, but...):

grep -rni num_threads imgsrv
imgsrv/bin/recompress:18:IPC::Run::run([ "/l/local/bin/kdu_expand", "-num_threads", "0", "-quiet", "-i", $image_filename, "-o", $tmp_filename, "-reduce", "$reduce" ]);
imgsrv/bin/recompress:19:IPC::Run::run([ "/l/local/bin/kdu_compress", "-num_threads", "0", "-quiet", "-i", $tmp_filename, "-o", "$final_filename", "-slope", "42988" ]);
imgsrv/lib/Process/Image.pm:197:                "-num_threads", "0", 
imgsrv/lib/Process/Image.pm:459:                "-num_threads", "0",

This is the only outstanding issue I wanted to note.

[aelkiss]

There are a total of five uses of the old grok -num_threads option. I would recommend changing the remaining four to use -H (I have no experience with recompress so I don't know if it is needed, but...):

grep -rni num_threads imgsrv
imgsrv/bin/recompress:18:IPC::Run::run([ "/l/local/bin/kdu_expand", "-num_threads", "0", "-quiet", "-i", $image_filename, "-o", $tmp_filename, "-reduce", "$reduce" ]);
imgsrv/bin/recompress:19:IPC::Run::run([ "/l/local/bin/kdu_compress", "-num_threads", "0", "-quiet", "-i", $tmp_filename, "-o", "$final_filename", "-slope", "42988" ]);
imgsrv/lib/Process/Image.pm:197:                "-num_threads", "0", 
imgsrv/lib/Process/Image.pm:459:                "-num_threads", "0",

This is the only outstanding issue I wanted to note.

These are all for Kakadu (kdu_expand or kdu_compress) rather than grokj2k. We may still be using a (very old) version of it in production -- it's at least still installed -- and we're not licensed for newer versions. Worth testing more thoroughly with a test machine with Debian 13.

[moseshll]

Oh silly me, I didn't even stop to think that we still had kakadu in the mix. Likely false alarm then, sorry.