Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: make findImportMap async #30

Merged
merged 1 commit into from
Oct 2, 2023
Merged

opt: make findImportMap async #30

merged 1 commit into from
Oct 2, 2023

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Oct 2, 2023

This is just a small optimization since it kind of annoyed me that this block while the importMap are supposed to run in parallel (for multiple entry-points).

The new lint can't catch this, because deno lints are purely syntax based.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Oct 2, 2023

Or maybe it can , with too much work, for example consider eaech function thave inside it a deno sync api a blocking function, and save it on a list and now each time we see it we also consider the parent blocking and so on, and now if we see one of these in an async context we emit a warning , that would be cool.

@hasundue
Copy link
Owner

hasundue commented Oct 2, 2023

Or maybe it can , with too much work, for example consider eaech function thave inside it a deno sync api a blocking function, and save it on a list and now each time we see it we also consider the parent blocking and so on, and now if we see one of these in an async context we emit a warning , that would be cool.

Interesting. Maybe we propose this to deno_lint...oh you already did 👍
denoland/deno_lint#1198

The change here sounds good anyways. Thanks, you're my ace.

@hasundue hasundue merged commit 6c1a47c into hasundue:main Oct 2, 2023
1 check passed
@sigmaSd
Copy link
Contributor Author

sigmaSd commented Oct 2, 2023

Thanks as well, nice projects you have 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants