docs: Update README #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghaas
reviewed
Oct 3, 2024
README.md
Outdated
Comment on lines
38
to
40
| | Palm | `>=16.0, <17` | `quince` | `>=2.1.0, <3.4.0` | | ||
| | Quince | `>=17.0, <18` | `quince` | `>=3.1.0, <3.4.0` | | ||
| | Redwood[^journal] | `>=18.0, <19` | `main` | `>=3.3.0` | |
There was a problem hiding this comment.
I think that since we are effectively dropping support for any release prior to Redwood, we should bump the major number on the next release. Which would mean that it should be this instead:
Suggested change
| | Palm | `>=16.0, <17` | `quince` | `>=2.1.0, <3.4.0` | | |
| | Quince | `>=17.0, <18` | `quince` | `>=3.1.0, <3.4.0` | | |
| | Redwood[^journal] | `>=18.0, <19` | `main` | `>=3.3.0` | | |
| | Palm | `>=16.0, <17` | `quince` | `>=2.1.0, <4` | | |
| | Quince | `>=17.0, <18` | `quince` | `>=3.1.0, <4` | | |
| | Redwood[^journal] | `>=18.0, <19` | `main` | `>=4` | |
... or can you think of a reason why that would be a terrible idea?
There was a problem hiding this comment.
Well a major release bump makes sense yes, but for Redwood we should still set >=3.3.0 to match the Changelog entries, no?
There was a problem hiding this comment.
I don't see that necessity, to be honest. That we started to support Redwood in 3.3.0 doesn't keep us from saying we now only want to support it with 4.0.0 forward. Wouldn't you agree?
mrtmm
force-pushed
the
drop-python3.8
branch
2 times, most recently
from
8cbb109 to
40058e7
Compare
Update the compatibility matrix with correct plugin versions and branches.
fghaas
approved these changes
Oct 3, 2024
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the compatibility matrix with correct plugin versions and branches.