Skip to content

Organize projects page by project status. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

myShoggoth
Copy link
Contributor

No description provided.

@goldfirere
Copy link
Contributor

Perhaps I should know how to do this, but how can I preview the new page?

@myShoggoth
Copy link
Contributor Author

Perhaps I should know how to do this, but how can I preview the new page?

I wish it were simple, and getting screenshots is not, either (at least on Windows). If you have Nix locally you can ./build.sh and ./watch.sh

@tomjaguarpaw
Copy link
Contributor

We could set up a Github action to install Nix and then run ./build.sh and ./watch.sh, putting the result in an artifact. That's what Tikhon Jelvis and I did for the Haskell.org repo

https://github.com/haskell-infra/www.haskell.org/blob/ed21e6f047ee64dc33bdc615096d810ec251f4bb/.github/workflows/main.yml#L14

It's probably a good few hours work to get running, unless one is very familiar with both Nix and Github actions, so I'm not sure where this comes in the relative priority of tasks for the site of HF in general.

@myShoggoth
Copy link
Contributor Author

We have #23 to try to encapsulate what we want here. What I'd ideally like:

  1. When a CI build happens it generates the site via Hakyll, which is automatically checked in so you don't have to do that yourself. Ideally it would be in a different branch or something. I did https://github.com/myShoggoth/myShoggoth.github.io/blob/hakyll/.circleci/config.yml for my own website using Hakyll.
  2. It would be extra cool to have the build results for PRs put on some url so people could try it out, like "branches.haskell.foundation/", but that gets much more complex.
  3. I believe the nix infrastructure here exists to enable a bunch of CSS/JS infrastructure. I'm not sure we really need all that complexity, if we could remove the Nix dependency it would be much easier to work on the site and see it locally.

@Kleidukos
Copy link
Contributor

Here is a screenshot of the new page
image

Copy link
Contributor

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having reviewed the changes, LGTM.

@myShoggoth myShoggoth merged commit 879361b into master Aug 12, 2021
@myShoggoth myShoggoth deleted the project_statuses branch August 12, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants