Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

Add Vision document to pages#45

Merged
emilypi merged 4 commits intohaskellfoundation:masterfrom
emilypi:emily/vision-document
Jan 11, 2021
Merged

Add Vision document to pages#45
emilypi merged 4 commits intohaskellfoundation:masterfrom
emilypi:emily/vision-document

Conversation

@emilypi
Copy link
Copy Markdown
Collaborator

@emilypi emilypi commented Jan 8, 2021

What? (required)

Adds Simon's HF Vision document content

Why? (optional)

Addresses #33, and because he asked me to!

How can this be tested? (optional)

N/A

Screenshots (optional)

[incoming]


The Haskell community comprises an amazing group of technical talent, and functions today as an almost entirely volunteer effort. The Haskell Foundation will not change that. Our goal is to make every member of the Haskell community, and every Haskell committee, feel more supported, and more productive. We want to enlarge and diversify our community going forward. Here’s a picture:

![Glue among the teams](https://i.imgur.com/kl8er0v.png)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do better than an imgur link here. Don't know how tho. Help please!

Copy link
Copy Markdown
Collaborator

@rebeccaskinner rebeccaskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well overall, but the header links now wrap because the additional vision link causes us to overflow the size of the header box.

The most straightforward solution here would be to change the maxWidth property of the container in src/components/Header.js:157 from lg to false; this disables the max width of the header container, which unfortunately means that if the window is maximized on a larger screen the header is now much wider than the content.

Relevant documentation seems to be here: https://material-ui.com/api/container/

There isn't any existing CSS setting the widths so we might be able to fix that by adding new CSS, but I'm not quite sure where that would go- perhaps in src/GlobalStyles.js ?

Copy link
Copy Markdown
Collaborator

@rebeccaskinner rebeccaskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vision

This works in my local testing and the changes look good.

@emilypi emilypi merged commit 72837bf into haskellfoundation:master Jan 11, 2021
@emilypi emilypi deleted the emily/vision-document branch January 11, 2021 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants