-
Notifications
You must be signed in to change notification settings - Fork 90
Add tracking of cabal files #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was just about to ask about this in the hls pr, many thanks! |
Yes, I built it via npm install, launched vscode and pressed f5 which launches a new vscode editor and then i opened a simple project in this editor and checked to see whether I could format a cabal file. |
nice, thank for the info, good to merge then |
@jneira Please don't forget that this PR must not be published unless haskell/haskell-language-server#2047 has been merged, otherwise we will display errors for all users. We should probably write that down somewhere? Maybe we also should think about a backwards compat story, as people might not immediately upgrade their HLS version to the latest available. |
Hmm you are rigth, thanks for noting it. Could we do some change in the hls part (or the extension) to avoid those errors? To investigate. |
I think we can check in the vscode plugin for the version of the hls and hls-wrapper version to launch and conditionally enable loading of cabal files. |
Allows tracking of cabal files so the cabal-fmt plugin on hls can access cabal files in order to format them.