Skip to content

Add tracking of cabal files #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

VeryMilkyJoe
Copy link
Collaborator

Allows tracking of cabal files so the cabal-fmt plugin on hls can access cabal files in order to format them.

@jneira
Copy link
Member

jneira commented Jul 29, 2021

I was just about to ask about this in the hls pr, many thanks!
Have you checked it works with the plugin?

@VeryMilkyJoe
Copy link
Collaborator Author

Yes, I built it via npm install, launched vscode and pressed f5 which launches a new vscode editor and then i opened a simple project in this editor and checked to see whether I could format a cabal file.
Cabal files are briefly underlined red upon opening them as they treated as haskell files by hls which I still need to fix.

@jneira
Copy link
Member

jneira commented Jul 29, 2021

nice, thank for the info, good to merge then

@jneira jneira merged commit c661eab into haskell:master Jul 29, 2021
@fendor
Copy link
Collaborator

fendor commented Jul 30, 2021

@jneira Please don't forget that this PR must not be published unless haskell/haskell-language-server#2047 has been merged, otherwise we will display errors for all users. We should probably write that down somewhere?

Maybe we also should think about a backwards compat story, as people might not immediately upgrade their HLS version to the latest available.

@jneira
Copy link
Member

jneira commented Jul 30, 2021

Hmm you are rigth, thanks for noting it. Could we do some change in the hls part (or the extension) to avoid those errors? To investigate.
Will do a release without this change in the meanwhile.

@fendor
Copy link
Collaborator

fendor commented Jul 30, 2021

I think we can check in the vscode plugin for the version of the hls and hls-wrapper version to launch and conditionally enable loading of cabal files.

jneira added a commit that referenced this pull request Aug 4, 2021
jneira added a commit that referenced this pull request Aug 8, 2021
jneira added a commit to jneira/vscode-haskell that referenced this pull request Aug 25, 2021
…files"

Reverting temporary the tracking of cabal file
as the hls plugin is delayed and we should not release
this change accidentally

This reverts commit c661eab, reversing
changes made to a15678e.
@jneira jneira mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants