Skip to content

Add iconcatMap #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add iconcatMap #531

wants to merge 4 commits into from
+60 −7

Conversation

toyboot4e
Copy link
Contributor

Closes #530 if merged. This PR contains:

  • The implementations in Data.Vector.Generic
  • Re-exports of them
  • And the property tests

@Shimuuar
Copy link
Contributor

PR looks good

Whether these function should included. I lean yes: we usually provide functions in 4 flavors: with/without index and monadic variants. So this brings up question which functions should be included? We have quite large API already

@toyboot4e toyboot4e changed the title Add iconcatMap, concatMapM and iconcatMapM Add iconcatMap Jun 14, 2025
@toyboot4e
Copy link
Contributor Author

I removed concatMapM and iconcatMapM from this PR. Let's add iconcatMap, as it would look natural in Hackage:

iconcatMap

Other missing functions would be monadic variants of concatMap and scan. I'd keep them in my private repository for now.

@toyboot4e toyboot4e marked this pull request as ready for review June 14, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More concatMap functions (indexed and mutable)
2 participants
@toyboot4e @Shimuuar