Skip to content

Upgrade to ghc 9.12 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to ghc 9.12 #491

wants to merge 1 commit into from

Conversation

GuillaumedeVolpiano
Copy link

@GuillaumedeVolpiano GuillaumedeVolpiano commented Apr 6, 2025 •
edited
Loading

Building on #480, this makes stylish-haskell functionally complete for ghc-9.12. Only one failing test left.

@GuillaumedeVolpiano GuillaumedeVolpiano mentioned this pull request Apr 7, 2025
Merged
@GuillaumedeVolpiano GuillaumedeVolpiano force-pushed the ghc9.12 branch 7 times, most recently from b78c138 to 2e0e410 Compare April 7, 2025 10:52
@Miezhiko
Copy link
Contributor

Miezhiko commented Apr 7, 2025

tested with my setup it works \o/ thank you

@GuillaumedeVolpiano
Copy link
Author

tested with my setup it works \o/ thank you

Nearly. There is a niche issue when you have a comment between the data declaration and the first constructor.

@GuillaumedeVolpiano
Copy link
Author

@Miezhiko Ignore my previous comment. All tests pass. Insert victory danse here.

@GuillaumedeVolpiano GuillaumedeVolpiano changed the title Upgrade to Ghc9.12 Upgrade to ghc 9.12 Apr 7, 2025
@GuillaumedeVolpiano GuillaumedeVolpiano force-pushed the ghc9.12 branch 4 times, most recently from 52f9622 to bace5b7 Compare April 13, 2025 10:32
@GuillaumedeVolpiano
Copy link
Author

@jaspervdj : this should be ready for review.
@jhrcek : happy to take any suggestions you might have.

@jaspervdj
Copy link
Member

@GuillaumedeVolpiano Thanks a lot! I will cut a release (v0.15.0.0) from main before merging this in.

jhrcek
jhrcek approved these changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great.
Just a small suggestion.

jaspervdj
jaspervdj approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@jaspervdj jaspervdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@GuillaumedeVolpiano
Copy link
Author

I had removed Data.List.foldl' from the imports of SimpleAlign, turns out ghc 9.8 still needs it, so I brought it back

@GuillaumedeVolpiano
Copy link
Author

Oh, so we're hitting the same bug with ghc-lib-parser-9.12 and ghc-9.8 that I'm hitting on Gentoo.

digital-asset/ghc-lib#595

Shall we just limit the versions to ghc-9.10 and ghc-9.12 until ghc-lib makes a release fixing this? I'll see if I can patch it, but it might take time to get to release. What do you think?

@jaspervdj
Copy link
Member

Okay, yeah, I think limiting it is fine given that we just made a release supporting ghc-9.6 and ghc-9.8.

@GuillaumedeVolpiano
Copy link
Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrcek jhrcek jhrcek approved these changes

@jaspervdj jaspervdj jaspervdj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumedeVolpiano @Miezhiko @jaspervdj @jhrcek