Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat undefined and null initialization options the same way #605

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

dschrempf
Copy link
Contributor

@dschrempf dschrempf commented Feb 16, 2025

Fixes #604 .

Also:

  • Overhaul nix configuration (add Flakes and nix-shell compatibility layer).
  • Fix a typo.

EDIT: Seems to work on my side, has the same effect as haskell/haskell-language-server#4498 for HLS.

- allow usage of Nix Flakes
- remove `niv` code (may be a controversial change)
- redirect `nix-shell` to `flake.nix`
Treat non-existing "initializationOptions", and `"initializationOptions": null`
the same way.

Fixes haskell#604
@dschrempf dschrempf marked this pull request as ready for review February 16, 2025 20:02
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michaelpj michaelpj enabled auto-merge (squash) February 19, 2025 22:06
@michaelpj michaelpj merged commit bd0217c into haskell:master Feb 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing "initializationOptions": null should not omit a warning
2 participants