Skip to content

CI: Fix hls-eval-plugin tests for GHC-9.10 #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Jun 19, 2025

hls-eval-plugin tests are currently failing in CI with:

Test output was different from 'plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs'. Output of ["git","-c","core.fileMode=false","diff","--no-index","--text","--exit-code","plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs","/tmp/TPropertyError.ghc910.expected89418-27.actual"]:
    diff --git a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs b/tmp/TPropertyError.ghc910.expected89418-27.actual
    index e3208e3..87fbda0 100644
    --- a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs
    +++ b/tmp/TPropertyError.ghc910.expected89418-27.actual
    @@ -10,4 +10,8 @@ module TProperty where
     --     errorEmptyList, called at libraries/ghc-internal/src/GHC/Internal/List.hs:96:11 in ghc-internal:GHC.Internal.List
     --     badHead, called at libraries/ghc-internal/src/GHC/Internal/List.hs:90:28 in ghc-internal:GHC.Internal.List
     --     head, called at <interactive>:1:27 in interactive:Ghci2
    +--   HasCallStack backtrace:
    +--     collectBacktraces, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:92:13 in ghc-internal:GHC.Internal.Exception
    +--     toExceptionWithBacktrace, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:128:3 in ghc-internal:GHC.Internal.Exception
    +--   
     -- []

This change fixes the failing test

@sgillespie sgillespie changed the title WIP: CI: Fix hls-eval-plugin tests for GHC-9.10 CI: Fix hls-eval-plugin tests for GHC-9.10 Jun 19, 2025
@sgillespie sgillespie marked this pull request as ready for review June 20, 2025 00:03
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couldn't figure out what causes this change in behaviour, though.
In a quick and dirty comparison of the plan.json files, the packages were identical.
Also, I had to run cabal update before seeing this test failure.
Couldn't reprodudce with this index-state: cabal v2-update 'hackage.haskell.org,2025-06-12T07:34:50Z'
It seems to be failing with:
cabal v2-update 'hackage.haskell.org,2025-06-20T03:34:40Z'

Also, I get a much bigger diff:

diff --git a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs b/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs
index e3208e37f..089779ea2 100644
--- a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs
+++ b/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs
@@ -10,4 +10,12 @@ module TProperty where
 --     errorEmptyList, called at libraries/ghc-internal/src/GHC/Internal/List.hs:96:11 in ghc-internal:GHC.Internal.List
 --     badHead, called at libraries/ghc-internal/src/GHC/Internal/List.hs:90:28 in ghc-internal:GHC.Internal.List
 --     head, called at <interactive>:1:27 in interactive:Ghci2
+--   HasCallStack backtrace:
+--     collectBacktraces, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:169:13 in ghc-internal:GHC.Internal.Exception
+--     toExceptionWithBacktrace, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:204:5 in ghc-internal:GHC.Internal.Exception
+--     error, called at libraries/ghc-internal/src/GHC/Internal/List.hs:2030:3 in ghc-internal:GHC.Internal.List
+--     errorEmptyList, called at libraries/ghc-internal/src/GHC/Internal/List.hs:96:11 in ghc-internal:GHC.Internal.List
+--     badHead, called at libraries/ghc-internal/src/GHC/Internal/List.hs:90:28 in ghc-internal:GHC.Internal.List
+--     head, called at <interactive>:1:27 in interactive:Ghci2
+--   
 -- []

As CI is green now, we should merge it to unblock the other PRs, but some more invetigation seems to be required.

@fendor fendor added the merge me Label to trigger pull request merge label Jun 20, 2025
@mergify mergify bot merged commit 256f834 into haskell:master Jun 20, 2025
37 checks passed
@sgillespie sgillespie deleted the fix/ci-9.10 branch June 20, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants