replace usages of NormalizedFilePath with NormalizedUri wherever possible #4622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangoIV
changed the title
|
oh no already three conflicts 😭 |
MangoIV
force-pushed
the
mangoiv/uri
branch
2 times, most recently
from
5552c2f to
26c5db8
Compare
MangoIV
commented
Jul 15, 2025
Comment on lines
-268
to
+275
| -- | Runs the action until it ends or until the given MVar is put. | ||
| -- | Runs the action until it ends or until the given MVar is put or the thread to fill the mvar is dropped, in which case the MVar will never be filled. | ||
| -- This happens when the thread that handles the shutdown notification dies. Ideally, this should not rely on the RTS detecting the blocked MVar | ||
| -- and instead *also* run the shutdown inf a finally block enclosing the handlers. In which case the BlockedIndefinitelyOnMVar Exception also wouldn't | ||
| -- be thrown. | ||
| -- Rethrows any exceptions. | ||
| untilMVar :: MonadUnliftIO m => MVar () -> m () -> m () | ||
| untilMVar mvar io = void $ | ||
| waitAnyCancel =<< traverse async [ io , readMVar mvar ] | ||
| untilMVar mvar io = race_ (readMVar mvar `catch` \BlockedIndefinitelyOnMVar -> pure ()) io |
There was a problem hiding this comment.
this bit is interesting for a reviewer
MangoIV
changed the title
This is the right thing to do because othewise it is not possible to create new ideStates in a single instance of the executable. This will be useful if the hls executable is supposed to talk to multiple clients and lives beyond a single client disconnecting.
Previously, when there was no shutdown message by a client and the client disconnected, resulting in the handlers to be GC'd the race that was supposed to free resources for the HieDB & co. would throw a hard error talking about the MVar being unreachable. We would like to instead finish gracefully because finishing the race as soon as the MVar was GC'd is the right thing to do anyway.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for being to run haskell-language-server against URIs that are not file URIs.
I am not sure about all the places and there's one more change that I will probably have to do to run HLS over websocket.